Attention is currently required from: jolly.

Patch set 3:Code-Review +1

View Change

3 comments:

• File include/onomondo/ipa/ipad.h:

  • Patch Set #3, Line 100: int ipa_disable_emergency_profile(struct ipa_context *ctx);

    maybe shorten "profile" to "prfle" and "emergency" to "emerg"?

• File src/ipa/libipa/es10b_dis_emerg_prfle.h:

  • Patch Set #3, Line 14: struct DisableEmergencyProfileResponse *res;

    Also here, maybe just return the integer result?

• File src/ipa/main.c:

  • Patch Set #3, Line 56: printf(" --disable-emergency-profile. Trigger return from emergency profile to previous profile\n");

    see my comment on an earlier patch of this series about options that are […]

    Acknowledged

To view, visit change 43044. To unsubscribe, or for help writing mail filters, visit settings.