Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43603?usp=email )
Change subject: osmo-trx-proxy: initial app skeleton ......................................................................
Patch Set 2:
(2 comments)
File proxy/include/osmocom/proxy/proxy.h:
https://gerrit.osmocom.org/c/osmo-trx/+/43603/comment/a9d8a2df_3b1a8017?usp=... : PS1, Line 23: struct proxy_ctx *proxy_ctx_alloc(void *talloc_ctx);
no _free()?
No. We do allocate only one instance of this struct and never free() it while the program is running. I could add the _free() counterpart for the sake of completeness, but at the moment it's not really needed.
File proxy/src/proxy.c:
https://gerrit.osmocom.org/c/osmo-trx/+/43603/comment/32f42b79_68fe329d?usp=... : PS1, Line 56: bool proxy_ctx_add_defaults_if_empty(struct proxy_ctx *proxy)
weird returning a bool here instead of return code.
Acknowledged