Attention is currently required from: laforge, pespin.

View Change

2 comments:

• File proxy/include/osmocom/proxy/proxy.h:

  • Patch Set #1, Line 23: struct proxy_ctx *proxy_ctx_alloc(void *talloc_ctx);

    no _free()?

    No. We do allocate only one instance of this struct and never free() it while the program is running. I could add the _free() counterpart for the sake of completeness, but at the moment it's not really needed.

• File proxy/src/proxy.c:

  • Patch Set #1, Line 56: bool proxy_ctx_add_defaults_if_empty(struct proxy_ctx *proxy)

    weird returning a bool here instead of return code.

    Acknowledged

To view, visit change 43603. To unsubscribe, or for help writing mail filters, visit settings.