Attention is currently required from: daniel, laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) Change subject: Add TCAP based loadsharing/routing ...................................................................... Patch Set 13: (8 comments) Patchset: PS13: Only small fixes needed, otherwise LGTM. File src/ss7_as.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/c81f9839_7da5b8... : PS8, Line 6: #include <osmocom/core/hashtable.h>
Here I would agree. Done
File src/ss7_as_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/224513e7_82c53d... : PS13, Line 185: unrelated, since you shouldn't be touching this function in this patch. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/6edaee27_c23411... : PS13, Line 196: as->cfg.loadshare.opc_shift = atoi(argv[5]); This change looks wrong, should be left untouched? https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/c0d49392_3f7bdd... : PS13, Line 214: #ifdef WITH_TCAP_LOADSHARING This should probably be removed from here, imho tcap routing should be independent of resetting the mtp3 traffic-mode. File src/ss7_asp.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/d494bf02_aded2a... : PS8, Line 96: bool enabled;
Does that make sense? why would somebody want to have TCAP routing enabled on some and not all of th […] Done
File src/tcap_as_loadshare.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/0a83ddd8_2e15c9... : PS13, Line 28: struct tcap_range *tcap_range_alloc(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp, Not blocking, but I think it's good practice to put the _alloc and _free function at the top of all the object functions. File tests/vty/Makefile.am: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/984e8fef_2c45fe... : PS13, Line 39: VTY_TEST_STP_DEFAULT += osmo_stp_test_tcap.vty EXTRA_DIST += osmo_stp_test_tcap.vty -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 13 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: daniel <dwillmann@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Thu, 27 Nov 2025 18:03:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: daniel <dwillmann@sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu>