Attention is currently required from: daniel, laforge, lynxis lazus.
8 comments:
Patchset:
Only small fixes needed, otherwise LGTM.
File src/ss7_as.h:
Patch Set #8, Line 6: #include <osmocom/core/hashtable.h>
Here I would agree.
Done
File src/ss7_as_vty.c:
unrelated, since you shouldn't be touching this function in this patch.
Patch Set #13, Line 196: as->cfg.loadshare.opc_shift = atoi(argv[5]);
This change looks wrong, should be left untouched?
Patch Set #13, Line 214: #ifdef WITH_TCAP_LOADSHARING
This should probably be removed from here, imho tcap routing should be independent of resetting the mtp3 traffic-mode.
File src/ss7_asp.h:
Patch Set #8, Line 96: bool enabled;
Does that make sense? why would somebody want to have TCAP routing enabled on some and not all of th […]
Done
File src/tcap_as_loadshare.h:
Patch Set #13, Line 28: struct tcap_range *tcap_range_alloc(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp,
Not blocking, but I think it's good practice to put the _alloc and _free function at the top of all the object functions.
File tests/vty/Makefile.am:
Patch Set #13, Line 39: VTY_TEST_STP_DEFAULT += osmo_stp_test_tcap.vty
EXTRA_DIST += osmo_stp_test_tcap.vty
To view, visit change 41309. To unsubscribe, or for help writing mail filters, visit settings.