Attention is currently required from: laforge, pespin. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32098 ) Change subject: common: implement rtp always-output mode ...................................................................... Patch Set 2: (3 comments) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32098/comment/6601730d_ae3b9968 PS2, Line 1250: /* A zero-length payload is never valid, it is merely a BFI marker
Can you explain a bit more this change in logic here? It's not explained in the commit description s […] The next iteration will include a comment in the code explaining that this check is for TrFO calls, i.e., call B DL coming from call A UL. If leg A sends out continuous-streaming BFI markers, then leg B needs to gracefully handle receiving such.
https://gerrit.osmocom.org/c/osmo-bts/+/32098/comment/efe15312_8c1763cc PS2, Line 1253: if (!resp_msg->len)
== 0 would be clearer here, since len is an int and not a bool. Will fix in the next iteration.
File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/32098/comment/0bd3b3b4_29b7805f PS2, Line 425: vty_out(vty, " rtp always-output%s", VTY_NEWLINE);
I know it always sucks to debate over naming, but I am certain it is worth the extra effort to make […] I struggled myself with the naming, and I was also less than 100% happy with my initial naming choice of "rtp always-output". But thanks to @laforge we now have a very good name as in "rtp continuous-streaming" - so that is the name I shall use in the next iteration of this patch series.
-- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic0e2edf2ed90ba0ac6bee5e7d9629bf0255e256d Gerrit-Change-Number: 32098 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 28 Mar 2023 16:06:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment