Attention is currently required from: laforge, pespin.

View Change

3 comments:

• File src/common/l1sap.c:

  • Patch Set #2, Line 1250: /* A zero-length payload is never valid, it is merely a BFI marker

    Can you explain a bit more this change in logic here? It's not explained in the commit description s […]

    The next iteration will include a comment in the code explaining that this check is for TrFO calls, i.e., call B DL coming from call A UL. If leg A sends out continuous-streaming BFI markers, then leg B needs to gracefully handle receiving such.

  • Patch Set #2, Line 1253: if (!resp_msg->len)

    == 0 would be clearer here, since len is an int and not a bool.

    Will fix in the next iteration.

• File src/common/vty.c:

  • Patch Set #2, Line 425: vty_out(vty, " rtp always-output%s", VTY_NEWLINE);

    I know it always sucks to debate over naming, but I am certain it is worth the extra effort to make […]

    I struggled myself with the naming, and I was also less than 100% happy with my initial naming choice of "rtp always-output". But thanks to @laforge we now have a very good name as in "rtp continuous-streaming" - so that is the name I shall use in the next iteration of this patch series.

To view, visit change 32098. To unsubscribe, or for help writing mail filters, visit settings.