Attention is currently required from: Hoernchen.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43172?usp=email )
Change subject: GP: LOAD/STORE DATA chunk size from SCP overhead ......................................................................
Patch Set 1: Code-Review+2 Verified+1
(3 comments)
Patchset:
PS1: I read through the patch and to me it looks plausible. I also gave it a quick manual test by installing a JAVA applet, which requires SCP02. Before this patch it does not work with Security Level 3, after applying the patch it works with Security Level 3 as well. So I can confirm it works.
File pySim/global_platform/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/43172/comment/90e5995d_52c3b813?usp=ema... : PS1, Line 871: load_parser.add_argument('--chunk-len', type=auto_uint8, default=None, (cosmetic, no blocker) as far as I know the default is always None, no need to set it explicitly.
File pySim/global_platform/scp.py:
https://gerrit.osmocom.org/c/pysim/+/43172/comment/55117bb9_dd23d59e?usp=ema... : PS1, Line 195: # is one byte less than the largest block-size multiple within 255 - mac_len. Would be nice to have a spec reference here (for the interested reader).