Attention is currently required from: Hoernchen.

Patch set 1:Verified +1Code-Review +2

3 comments:

Patchset:
- Patch Set #1:
  I read through the patch and to me it looks plausible. I also gave it a quick manual test by installing a JAVA applet, which requires SCP02. Before this patch it does not work with Security Level 3, after applying the patch it works with Security Level 3 as well. So I can confirm it works.
File pySim/global_platform/__init__.py:
- Patch Set #1, Line 871: load_parser.add_argument('--chunk-len', type=auto_uint8, default=None,
  (cosmetic, no blocker) as far as I know the default is always None, no need to set it explicitly.
File pySim/global_platform/scp.py:
- Patch Set #1, Line 195: # is one byte less than the largest block-size multiple within 255 - mac_len.
  Would be nice to have a spec reference here (for the interested reader).

To view, visit change 43172. To unsubscribe, or for help writing mail filters, visit settings.