Attention is currently required from: falconia, pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32714 )
Change subject: TCH DL, FR & EFR: reshape SIDs per 06.31/06.81 section 5.1.2 ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/1dede61f_a7bb9e35 PS2, Line 8: It might be helpful to mention DTX to make more clear what this is about. (At least I had to dig out the spec and look it up ;-)
File include/osmo-bts/lchan.h:
https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/a7577dab_27938f0f PS2, Line 281: } nonamr;
"fr_efr" instead of "noamr"? […]
I would rename it to fr_efr too. As far as I can see this is about DTX, so maybe lets rename it to dtx_fr_efr to make that more clear. We also should rename the dtx sub struct above to dtx_amr in a follow up patch.
https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/14c04255_63913940 PS2, Line 282: uint8_t last_cmr;
isn't this AMR specific? I find it a bit confusing that a "noamr" struct is put inside a struct cont […]
Its a sub struct "tch", so the location should be fine.
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/9f83b698_c275e36f PS2, Line 1334: bool is_nonamr_sid = false; better rename this to is_fr_efr_sid as well.