Attention is currently required from: falconia, pespin.
4 comments:
Commit Message:
It might be helpful to mention DTX to make more clear what this is about. (At least I had to dig out the spec and look it up ;-)
File include/osmo-bts/lchan.h:
Patch Set #2, Line 281: } nonamr;
"fr_efr" instead of "noamr"? […]
I would rename it to fr_efr too. As far as I can see this is about DTX, so maybe lets rename it to dtx_fr_efr to make that more clear. We also should rename the dtx sub struct above to dtx_amr in a follow up patch.
Patch Set #2, Line 282: uint8_t last_cmr;
isn't this AMR specific? I find it a bit confusing that a "noamr" struct is put inside a struct cont […]
Its a sub struct "tch", so the location should be fine.
File src/common/l1sap.c:
Patch Set #2, Line 1334: bool is_nonamr_sid = false;
better rename this to is_fr_efr_sid as well.
To view, visit change 32714. To unsubscribe, or for help writing mail filters, visit settings.