Jenkins Builder has posted comments on this change by tempest. ( https://gerrit.osmocom.org/c/osmo-trx/+/42811?usp=email )
Change subject: trx-usrp1: make single daughterboard VTY configurable ......................................................................
Patch Set 1:
(22 comments)
File CommonLibs/trx_vty.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/b475e6dc_713c360c?usp=... : PS1, Line 636: "usrp1-singledb (disable|enable)", code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/d54974cc_8b1260b8?usp=... : PS1, Line 636: "usrp1-singledb (disable|enable)", please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/1a320484_70bcb4d9?usp=... : PS1, Line 637: "Use single daughterboard on USRP1 (default=disable)\n" code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/f3440ab8_43f561ef?usp=... : PS1, Line 637: "Use single daughterboard on USRP1 (default=disable)\n" please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/ce3280c0_edcc37af?usp=... : PS1, Line 638: "Use dual daughterboard configuration (TX on DB A, RX on DB B)\n" code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/cb43ed5b_fc9159d6?usp=... : PS1, Line 638: "Use dual daughterboard configuration (TX on DB A, RX on DB B)\n" please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/559b528b_c37085cd?usp=... : PS1, Line 639: "Use single daughterboard configuration (TX/RX on DB A)\n") code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/b5fb8fe6_20e3cf5a?usp=... : PS1, Line 639: "Use single daughterboard configuration (TX/RX on DB A)\n") please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/79a3de56_e58266a7?usp=... : PS1, Line 641: struct trx_ctx *trx = trx_from_vty(vty); code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/96f2cfed_a9e41985?usp=... : PS1, Line 641: struct trx_ctx *trx = trx_from_vty(vty); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/bc2c505d_75d8c235?usp=... : PS1, Line 643: if (strcmp("disable", argv[0]) == 0) code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/44edb7e7_aa75f4f3?usp=... : PS1, Line 643: if (strcmp("disable", argv[0]) == 0) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/d97ebfd4_6a589113?usp=... : PS1, Line 644: trx->cfg.usrp1_singledb = false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/7eb34edf_6b0196f1?usp=... : PS1, Line 644: trx->cfg.usrp1_singledb = false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/6a12ae70_52d31e19?usp=... : PS1, Line 646: if (strcmp("enable", argv[0]) == 0) code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/0aa7d2f2_b623a464?usp=... : PS1, Line 646: if (strcmp("enable", argv[0]) == 0) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/7b587387_7b0f93e8?usp=... : PS1, Line 647: trx->cfg.usrp1_singledb = true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/3819a4f4_512e35e6?usp=... : PS1, Line 647: trx->cfg.usrp1_singledb = true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/9f6fc803_c8ef46b2?usp=... : PS1, Line 649: return CMD_SUCCESS; code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/d74582c4_91c48baf?usp=... : PS1, Line 649: return CMD_SUCCESS; please, no spaces at the start of a line
File doc/manuals/chapters/trx-backends.adoc:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/f2f985c7_07bee358?usp=... : PS1, Line 69: By default, osmo-trx-usrp1 will use daughterboard A for transmitting and trailing whitespace
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/a6c9c4bf_68f83918?usp=... : PS1, Line 70: daughterboard B for receiving. Some USRP1 configurations use only a single trailing whitespace