View Change

22 comments:

• File CommonLibs/trx_vty.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 636: "usrp1-singledb (disable|enable)",

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 636: "usrp1-singledb (disable|enable)",

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 637: "Use single daughterboard on USRP1 (default=disable)\n"

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 637: "Use single daughterboard on USRP1 (default=disable)\n"

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 638: "Use dual daughterboard configuration (TX on DB A, RX on DB B)\n"

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 638: "Use dual daughterboard configuration (TX on DB A, RX on DB B)\n"

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 639: "Use single daughterboard configuration (TX/RX on DB A)\n")

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 639: "Use single daughterboard configuration (TX/RX on DB A)\n")

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 641: struct trx_ctx *trx = trx_from_vty(vty);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 641: struct trx_ctx *trx = trx_from_vty(vty);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 643: if (strcmp("disable", argv[0]) == 0)

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 643: if (strcmp("disable", argv[0]) == 0)

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 644: trx->cfg.usrp1_singledb = false;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 644: trx->cfg.usrp1_singledb = false;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 646: if (strcmp("enable", argv[0]) == 0)

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 646: if (strcmp("enable", argv[0]) == 0)

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 647: trx->cfg.usrp1_singledb = true;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 647: trx->cfg.usrp1_singledb = true;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 649: return CMD_SUCCESS;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 649: return CMD_SUCCESS;

    please, no spaces at the start of a line

• File doc/manuals/chapters/trx-backends.adoc:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 69: By default, osmo-trx-usrp1 will use daughterboard A for transmitting and

    trailing whitespace

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 70: daughterboard B for receiving. Some USRP1 configurations use only a single

    trailing whitespace

To view, visit change 42811. To unsubscribe, or for help writing mail filters, visit settings.