Attention is currently required from: laforge, pespin, tnt.
manawyrm has posted comments on this change by manawyrm. ( https://gerrit.osmocom.org/c/osmo-e1d/+/43643?usp=email )
Change subject: octoi: rework frame_rifo logic to decompress frames on the output side ......................................................................
Patch Set 7:
(4 comments)
Patchset:
PS7: Another code-review, please? 😊
File src/octoi/e1oip.c:
https://gerrit.osmocom.org/c/osmo-e1d/+/43643/comment/f6970435_506b6d95?usp=... : PS5, Line 263: memcpy(frame_buf, iline->e1t.last_frame, BYTES_PER_FRAME);
It's not zeroed, it copies the last frame AFAICT
Acknowledged
File src/octoi/frame_rifo.c:
https://gerrit.osmocom.org/c/osmo-e1d/+/43643/comment/6db99812_1362e2ac?usp=... : PS5, Line 147: memcpy(out, rifo->last_out, BYTES_PER_FRAME);
This doesn't really do anything since AFAICT the code further down will fill with 0xff if rc == -2
Acknowledged
File src/octoi/octoi.c:
https://gerrit.osmocom.org/c/osmo-e1d/+/43643/comment/c0051b26_abedddd8?usp=... : PS5, Line 140: /* substitute with last received frame */
"subsituted in frame_rifo_out()" looks more clear yes.
Acknowledged