Attention is currently required from: laforge, pespin, tnt.

View Change

4 comments:

• Patchset:

  • Patch Set #7:

    Another code-review, please? 😊

• File src/octoi/e1oip.c:

  • Patch Set #5, Line 263: memcpy(frame_buf, iline->e1t.last_frame, BYTES_PER_FRAME);

    It's not zeroed, it copies the last frame AFAICT

    Acknowledged

• File src/octoi/frame_rifo.c:

  • Patch Set #5, Line 147: memcpy(out, rifo->last_out, BYTES_PER_FRAME);

    This doesn't really do anything since AFAICT the code further down will fill with 0xff if rc == -2

    Acknowledged

• File src/octoi/octoi.c:

  • Patch Set #5, Line 140: /* substitute with last received frame */

    "subsituted in frame_rifo_out()" looks more clear yes.

    Acknowledged

To view, visit change 43643. To unsubscribe, or for help writing mail filters, visit settings.