Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35466?usp=email ) Change subject: core: osmo_tdef_fsm_inst_state_chg(): allow millisecond precision ...................................................................... Patch Set 4: (2 comments) Patchset: PS4:
should we immediately improve to full microsecond granularity, as in not repeat the earlier mistake? As long as there is a need for such a high granularity... AFAICS, `OSMO_TDEF_US` timers are not that common in the Osmocom codebase. @laforge@osmocom.org what do you think?
File src/core/tdef.c: https://gerrit.osmocom.org/c/libosmocore/+/35466/comment/d2890684_925cc8c5 PS4, Line 347: val = osmo_tdef_get(tdefs, t->T, OSMO_TDEF_S, default_timeout);
IIRC osmo_tdef_get(..., OSMO_TDEF_MS, ...) should do exactly what is intended here. […] No, I actually **had to** re-implement the logic of `osmo_tdef_get()` here. The main reason is that we need to check if `tdef->unit == OSMO_TDEF_CUSTOM` and convert the value in seconds to milliseconds. Otherwise, we would suddenly start treating `OSMO_TDEF_CUSTOM` values as milliseconds...
-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35466?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4c4ee89e7e32e86f74cd215f5cbfa44ace5426c1 Gerrit-Change-Number: 35466 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jan 2024 17:10:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Gerrit-MessageType: comment