Attention is currently required from: neels.

View Change

2 comments:

• Patchset:

  • Patch Set #4:

    should we immediately improve to full microsecond granularity, as in not repeat the earlier mistake?

    As long as there is a need for such a high granularity...
    AFAICS, `OSMO_TDEF_US` timers are not that common in the Osmocom codebase.
    @laforge@osmocom.org what do you think?

• File src/core/tdef.c:

  • Patch Set #4, Line 347: val = osmo_tdef_get(tdefs, t->T, OSMO_TDEF_S, default_timeout);

    IIRC osmo_tdef_get(..., OSMO_TDEF_MS, ...) should do exactly what is intended here. […]

    No, I actually **had to** re-implement the logic of `osmo_tdef_get()` here. The main reason is that we need to check if `tdef->unit == OSMO_TDEF_CUSTOM` and convert the value in seconds to milliseconds. Otherwise, we would suddenly start treating `OSMO_TDEF_CUSTOM` values as milliseconds...

To view, visit change 35466. To unsubscribe, or for help writing mail filters, visit settings.