2 Oct
2026
2 Oct
'26
12:43 p.m.
Attention is currently required from: jolly, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753?usp=email )
Change subject: ss7_asp_peer: Improvements in ss7_asp_peer_snprintf() ......................................................................
Patch Set 1:
(1 comment)
File src/ss7_asp_peer.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753/comment/65afdb01_c061e7... : PS1, Line 68: peer->host[0], What if `peer->host[0]` is an IPv4 address, but `peer->host[N]` (N > 0) is an IPv6?Also, I see below you're not adding the closing `]` if `peer->host_cnt > 1`.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I115951627adb0c6778a9a36159237c3eea130300
Gerrit-Change-Number: 43753
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: jolly andreas@eversberg.eu
Gerrit-Attention: jolly andreas@eversberg.eu
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Fri, 02 Oct 2026 10:43:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No