Attention is currently required from: jolly, pespin.
View Change
1 comment:
File src/ss7_asp_peer.c:
Patch Set #1, Line 68: peer->host[0],
What if `peer->host[0]` is an IPv4 address, but `peer->host[N]` (N > 0) is an IPv6?Also, I see below you're not adding the closing `]` if `peer->host_cnt > 1`.
To view, visit change 43753. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I115951627adb0c6778a9a36159237c3eea130300
Gerrit-Change-Number: 43753
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: jolly <andreas@eversberg.eu>
Gerrit-Attention: jolly <andreas@eversberg.eu>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Oct 2026 10:43:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No