Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email )
Change subject: libosmo-trx/ep: add TRX endpoint module ......................................................................
Patch Set 5: Code-Review+1
(2 comments)
File libosmo-trx/src/trx_ep.c:
https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/5eeae130_d3a0396c?usp=... : PS5, Line 427: talloc_free(ep->chans); /* re-alloc: free() and allocate again */ if (num_chans == ep->num_chans) return 0;
https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/5b168e01_c00d6b3e?usp=... : PS5, Line 433: ep->chans[n] = (struct osmo_trx_ep_chan){ FYI, having this is a static function trx_ep_chan_init() is handy later on when readers try to understand the lifecycle of such objects.