Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email ) Change subject: libosmo-trx/ep: add TRX endpoint module ...................................................................... Patch Set 5: Code-Review+1 (2 comments) File libosmo-trx/src/trx_ep.c: https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/5eeae130_d3a0396c?usp=... : PS5, Line 427: talloc_free(ep->chans); /* re-alloc: free() and allocate again */ if (num_chans == ep->num_chans) return 0; https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/5b168e01_c00d6b3e?usp=... : PS5, Line 433: ep->chans[n] = (struct osmo_trx_ep_chan){ FYI, having this is a static function trx_ep_chan_init() is handy later on when readers try to understand the lifecycle of such objects. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I767fa43a9ca88be40c385f6dcb9de22891a6afc3 Gerrit-Change-Number: 43111 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 03 Sep 2026 08:21:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes