Attention is currently required from: pespin. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32128 ) Change subject: rtp continuous-streaming: fix BFI in the quality-suppressed case ...................................................................... Patch Set 2: (1 comment) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32128/comment/bd1f4032_f0bf924a PS1, Line 1661: send_ul_rtp_packet(lchan, fn, bfi, 0);
well if len = 0, then it makes no sense to access to buffer, so it shouldn't expect it to be non-nul […] I just double-checked to be absolutely sure: when OsMux is used, the call boils down to osmo_rtp_build() in libosmo-netif, and in the non-OsMux case it boils down to rtp_session_create_packet() in the external-dependency ortp library. Both functions are explicitly OK with zero-length RTP payloads (length argument to the function equals 0), and in both functions the memcpy() call for payload bytes is explicitly skipped in the zero-length case, thus the data pointer argument is never used. So we all good.
-- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icee0f57be289a0592a0197469432a012d15f224c Gerrit-Change-Number: 32128 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 29 Mar 2023 19:43:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon@freecalypso.org> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment