Attention is currently required from: pespin.

View Change

1 comment:

• File src/common/l1sap.c:

  • Patch Set #1, Line 1661: send_ul_rtp_packet(lchan, fn, bfi, 0);

    well if len = 0, then it makes no sense to access to buffer, so it shouldn't expect it to be non-nul […]

    I just double-checked to be absolutely sure: when OsMux is used, the call boils down to osmo_rtp_build() in libosmo-netif, and in the non-OsMux case it boils down to rtp_session_create_packet() in the external-dependency ortp library. Both functions are explicitly OK with zero-length RTP payloads (length argument to the function equals 0), and in both functions the memcpy() call for payload bytes is explicitly skipped in the zero-length case, thus the data pointer argument is never used. So we all good.

To view, visit change 32128. To unsubscribe, or for help writing mail filters, visit settings.