Attention is currently required from: lynxis lazus.
laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email )
Change subject: firmware: Implement debug command via USB control vendor class ......................................................................
Patch Set 6:
(1 comment)
File firmware/libcommon/source/mode_cardemu.c:
https://gerrit.osmocom.org/c/simtrace2/+/43005/comment/5c6c88e1_db64a50c?usp... : PS6, Line 714: struct cardem_inst *ci = &cardem_inst[i]; I would simply definde a struct with named members at the simtrace protocol level, and then use that struct here to fill those named members. This way it's more or less self-documented, rather than storing things at magic offsets into a byte buffer.
that struct could also include a version number so we can later extend/modify it if we ever have more debug info to return?