Attention is currently required from: lynxis lazus.

View Change

1 comment:

• File firmware/libcommon/source/mode_cardemu.c:

  • Patch Set #6, Line 714: struct cardem_inst *ci = &cardem_inst[i];

    I would simply definde a struct with named members at the simtrace protocol level, and then use that struct here to fill those named members. This way it's more or less self-documented, rather than storing things at magic offsets into a byte buffer.

    that struct could also include a version number so we can later extend/modify it if we ever have more debug info to return?

To view, visit change 43005. To unsubscribe, or for help writing mail filters, visit settings.