Attention is currently required from: pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40494?usp=email ) Change subject: Send multiple read/recvfrom/recvmsg SQEs in advance ...................................................................... Patch Set 8: (10 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/b0f7bd16_7fd684d5?u... : PS7, Line 7: Send multiple read/recvfrom SQEs in advance
/recvmsg too from what I can see in the commit implementation. Done
File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/18563c78_6ed83ec8?u... : PS7, Line 52: #define IOFD_MSGHDR_READ_SQES 32
IOFD_MSGHDR_MAX_READ_SQES Done
https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/d682967f_fa5c7564?u... : PS7, Line 110: int read_len;
Documenting these fields here would be awesome. Done
File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/61911071_8e099969?u... : PS4, Line 122: if ((env = getenv(OSMO_IO_URING_READ_SQE))) {
Feel free to add an extra internal commit to force-enable it during benchmarking. […] Now it has both, one env for benchmarking and one API call for the application.
File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/333cb073_916574e2?u... : PS7, Line 240: iofd->u.uring.read_msghdr = NULL;
This one probably needs to be moved above around line 238? Done
https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/ebeefd79_9f1da12d?u... : PS7, Line 216: goto submit_again;
this goto can be implemented by simple recursive call: […] Done
https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/e5f6c023_9f7ce15d?u... : PS7, Line 231: LOGP(DLIO, LOGL_DEBUG, "Read SQE completion, but msghdr not found, please fix!\n");
sounds like LOGL_FATAL instead ;) Done
https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/87f450f1_9e5eba40?u... : PS7, Line 238:
missing =NULL for last read_msghdr? Done
https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/08a8a2cb_f67ca9a5?u... : PS7, Line 470: int idx;
unsigned int Done
https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/54f4a98b_c12a24af?u... : PS7, Line 473: msghdr = iofd->u.uring.read_msghdr[idx];
iofd->u.uring. […] Done
-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id50a8900fa2fe6de553e5025feae7e1e8d501e30 Gerrit-Change-Number: 40494 Gerrit-PatchSet: 8 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 28 Jul 2025 10:19:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas@eversberg.eu> Comment-In-Reply-To: pespin <pespin@sysmocom.de>