Attention is currently required from: pespin.

View Change

10 comments:

• Commit Message:

  • Patch Set #7, Line 7: Send multiple read/recvfrom SQEs in advance

    /recvmsg too from what I can see in the commit implementation.

    Done

• File src/core/osmo_io_internal.h:

  • Patch Set #7, Line 52: #define IOFD_MSGHDR_READ_SQES 32

    IOFD_MSGHDR_MAX_READ_SQES

    Done

  • Patch Set #7, Line 110: int read_len;

    Documenting these fields here would be awesome.

    Done

• File src/core/osmo_io_uring.c:

  • Patch Set #4, Line 122: if ((env = getenv(OSMO_IO_URING_READ_SQE))) {

    Feel free to add an extra internal commit to force-enable it during benchmarking. […]

    Now it has both, one env for benchmarking and one API call for the application.

• File src/core/osmo_io_uring.c:

  • Patch Set #7, Line 240: iofd->u.uring.read_msghdr = NULL;

    This one probably needs to be moved above around line 238?

    Done

  • Patch Set #7, Line 216: goto submit_again;

    this goto can be implemented by simple recursive call: […]

    Done

  • Patch Set #7, Line 231: LOGP(DLIO, LOGL_DEBUG, "Read SQE completion, but msghdr not found, please fix!\n");

    sounds like LOGL_FATAL instead ;)

    Done

  • Patch Set #7, Line 238:

    missing =NULL for last read_msghdr?

    Done

  • Patch Set #7, Line 470: int idx;

    unsigned int

    Done

  • Patch Set #7, Line 473: msghdr = iofd->u.uring.read_msghdr[idx];

    iofd->u.uring. […]

    Done

To view, visit change 40494. To unsubscribe, or for help writing mail filters, visit settings.