Attention is currently required from: laforge. hampushellsberg has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44007?usp=email ) Change subject: esim/asn1: add the SGP.22 v3.1 RSPDefinitions module as rsp_v3 ...................................................................... Patch Set 1: (1 comment) File pySim/esim/rsp.py: https://gerrit.osmocom.org/c/pysim/+/44007/comment/ce9dacbe_81c95b32?usp=ema... : PS1, Line 35: asn1_v3
is there a reason why this is defined as a function rather than as a global variable (like asn1 abov […] Yes: lru_cache runs the compile once, on the first call, and returns the same module after that. I kept it lazy because compiling the v3.1 module together with the SAIP and PKIX modules it imports takes about 0.4 s here (the v2 module about 0.2 s), and pySim.esim.rsp is imported by es8p, es9p, osmo-smdpp and the ES2+/ES9+ contrib tools, of which only osmo-smdpp uses v3 (for EUICCInfo1). As a module-level variable like asn1, every one of them would pay that at import. Would you rather have the variable anyway, for consistency with asn1?
-- To view, visit https://gerrit.osmocom.org/c/pysim/+/44007?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I670ec73f9958882a8d3fe4b589bdafa3fbf702ea Gerrit-Change-Number: 44007 Gerrit-PatchSet: 1 Gerrit-Owner: hampushellsberg <hampushellsberg@gmail.com> Gerrit-CC: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Mon, 02 Nov 2026 11:57:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org>