Attention is currently required from: laforge.
1 comment:
File pySim/esim/rsp.py:
Patch Set #1, Line 35: asn1_v3
is there a reason why this is defined as a function rather than as a global variable (like asn1 abov […]
Yes: lru_cache runs the compile once, on the first call, and returns the same module after that. I kept it lazy because compiling the v3.1 module together with the SAIP and PKIX modules it imports takes about 0.4 s here (the v2 module about 0.2 s), and pySim.esim.rsp is imported by es8p, es9p, osmo-smdpp and the ES2+/ES9+ contrib tools, of which only osmo-smdpp uses v3 (for EUICCInfo1). As a module-level variable like asn1, every one of them would pay that at import.
Would you rather have the variable anyway, for consistency with asn1?
To view, visit change 44007. To unsubscribe, or for help writing mail filters, visit settings.