Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32043 ) Change subject: logging: add 'logging timezone (localtime|utc)' ...................................................................... Patch Set 1: (3 comments) File src/core/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/32043/comment/d40f1ed3_33eb006c PS1, Line 874: target->timezone = timezone;
this should return an int and return an error if user wants to set a timezone for which we don't hav […] Ack
File src/vty/logging_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/32043/comment/000f5409_4cdd1a6b PS1, Line 203: log_set_timezone(tgt, LOG_TIMEZONE_UTC);
in here, chewck the error code returned and if it failed return CMD_WARNING with a logging saying th […] Ack
File tests/logging/logging_vty_test.vty: https://gerrit.osmocom.org/c/libosmocore/+/32043/comment/86cf9698_e2243625 PS1, Line 75: logging_vty_test# logging timestamp ?
you could add a "logging timezone ?" test here. See https://gerrit.osmocom.org/c/libosmocore/+/32044.
-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7f868b47bf8f8dfcf85e735f490ae69b18111af4 Gerrit-Change-Number: 32043 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Sat, 25 Mar 2023 13:57:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment