Attention is currently required from: neels, pespin.

View Change

3 comments:

• File src/core/logging.c:

  • Patch Set #1, Line 874: target->timezone = timezone;

    this should return an int and return an error if user wants to set a timezone for which we don't hav […]

    Ack

• File src/vty/logging_vty.c:

  • Patch Set #1, Line 203: log_set_timezone(tgt, LOG_TIMEZONE_UTC);

    in here, chewck the error code returned and if it failed return CMD_WARNING with a logging saying th […]

    Ack

• File tests/logging/logging_vty_test.vty:

  • Patch Set #1, Line 75: logging_vty_test# logging timestamp ?

    you could add a "logging timezone ?" test here.

    See https://gerrit.osmocom.org/c/libosmocore/+/32044.

To view, visit change 32043. To unsubscribe, or for help writing mail filters, visit settings.