Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36520?usp=email ) Change subject: fixup for re-est: do not succeed on acceptance fail ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/36520/comment/38ec6d3f_8a242e2c PS1, Line 18: Related: SYS#5130
Fixes: ae98b97382285420ba81549bc874b9fea5e7daa9 never seen this header pointing at a commit hash before. "Fixes:" is about issue numbers. AFAIK we hardly ever use this header. I've never used it before and it has not been indicated that i should, so where is this coming from?
File src/libmsc/msc_a.c: https://gerrit.osmocom.org/c/osmo-msc/+/36520/comment/1e89b76a_e1b1e176 PS1, Line 165: if (conn_accepted) {
Can we please try refactoring this function? I see "if (conn_accepted)" spread like in 4 different p […] the argument goes both ways. if you prefer the other way, then i guess you can suggest a refactoring. i'm not going to spend time on it, because IMHO this is bad style:
if (conn_accepted) { update_counters(fi, true); ... } else { update_counters(fi, false); ... } instead of just update_counters(fi, conn_accepted); as we have now. resolving because it's about code prior to this patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36520?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3679162143e8d7d8c0878de2102faa11eadfccfc Gerrit-Change-Number: 36520 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 03 Apr 2024 23:27:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment