Attention is currently required from: pespin.

2 comments:

Commit Message:
- Patch Set #1, Line 18: Related: SYS#5130
  Fixes: ae98b97382285420ba81549bc874b9fea5e7daa9
  never seen this header pointing at a commit hash before. "Fixes:" is about issue numbers. AFAIK we hardly ever use this header. I've never used it before and it has not been indicated that i should, so where is this coming from?
File src/libmsc/msc_a.c:
- Patch Set #1, Line 165: if (conn_accepted) {
  Can we please try refactoring this function? I see "if (conn_accepted)" spread like in 4 different p […]
  the argument goes both ways. if you prefer the other way, then i guess you can suggest a refactoring. i'm not going to spend time on it, because IMHO this is bad style:
```
    if (conn_accepted) {
          update_counters(fi, true);
          ...
    } else {
          update_counters(fi, false);
          ...
    }
    
instead of just
```
```
    update_counters(fi, conn_accepted);
    
as we have now.
```
  resolving because it's about code prior to this patch.

To view, visit change 36520. To unsubscribe, or for help writing mail filters, visit settings.