Attention is currently required from: laforge.
fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37848?usp=email )
Change subject: pySim.esim.saip: maintain a parsed fileystem hierarchy ......................................................................
Patch Set 4:
(1 comment)
File pySim/esim/saip/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/37848/comment/31679e21_358f4fef?usp=ema... : PS1, Line 100: def __init__(self, pename: str, l: Optional[List[Tuple]] = None, template: :
I don't get the **kwargs argument, but I've added the name docstring.
I meant making the constructor accept `**kw` rather than adding even more `Optional` parameters:
``` def __init__(self, pename: str, **kw): self.foo: FooType = kw.get('foo') self.bar: BarType = kw.get('bar') if 'l' in kw: self.from_tuples(kw['l']) ```
This way the method declaration is more readable. This is a usual practice in Python. Not critical.