Attention is currently required from: laforge.

View Change

1 comment:

• File pySim/esim/saip/__init__.py:

  • Patch Set #1, Line 100:

        def __init__(self, pename: str, l: Optional[List[Tuple]] = None, template:
      
    

    I don't get the **kwargs argument, but I've added the name docstring.

    I meant making the constructor accept `**kw` rather than adding even more `Optional` parameters:

    ```
    def __init__(self, pename: str, **kw):
        self.foo: FooType = kw.get('foo')
        self.bar: BarType = kw.get('bar')
        if 'l' in kw:
            self.from_tuples(kw['l'])
    ```

    This way the method declaration is more readable.
    This is a usual practice in Python. Not critical.

To view, visit change 37848. To unsubscribe, or for help writing mail filters, visit settings.