Attention is currently required from: lynxis lazus.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email )
Change subject: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection ......................................................................
Patch Set 10:
(6 comments)
File src/sgsn/sgsn_libgtp.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/269737b5_1b12a0d7?usp... : PS10, Line 908: #define CHECK_SPACE_ERR(bytes) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/cc1ee420_a9e16c2c?usp... : PS10, Line 913: #define MEMCPY_CHK(dst, src, len) \ Macros with multiple statements should be enclosed in a do - while loop
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/c114a8f1_9bfdfb15?usp... : PS10, Line 913: #define MEMCPY_CHK(dst, src, len) \ macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/19a4cc5d_7c92aa1b?usp... : PS10, Line 1120: if (buf_len <= 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/165e71b4_1aeb0901?usp... : PS10, Line 1134: // break; please, no space before tabs
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/39e5b9e9_70fdc51d?usp... : PS10, Line 1373: strncpy(mmctx->imsi, imsi_str, sizeof(mmctx->imsi)); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()