Attention is currently required from: lynxis lazus.

View Change

6 comments:

• File src/sgsn/sgsn_libgtp.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #10, Line 908: #define CHECK_SPACE_ERR(bytes) \

    Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects

  • Robot Comment from checkpatch (run ID ):

    Patch Set #10, Line 913: #define MEMCPY_CHK(dst, src, len) \

    Macros with multiple statements should be enclosed in a do - while loop

  • Robot Comment from checkpatch (run ID ):

    Patch Set #10, Line 913: #define MEMCPY_CHK(dst, src, len) \

    macros should not use a trailing semicolon

  • Robot Comment from checkpatch (run ID ):

    Patch Set #10, Line 1120: if (buf_len <= 0) {

    braces {} are not necessary for single statement blocks

  • Robot Comment from checkpatch (run ID ):

    Patch Set #10, Line 1134: // break;

    please, no space before tabs

  • Robot Comment from checkpatch (run ID ):

    Patch Set #10, Line 1373: strncpy(mmctx->imsi, imsi_str, sizeof(mmctx->imsi));

    Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()

To view, visit change 39563. To unsubscribe, or for help writing mail filters, visit settings.