Attention is currently required from: Hoernchen, daniel, lynxis lazus.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43547?usp=email )
Change subject: contrib: SCP81 TLS-PSK RAS for RAM/RFM over HTTPS ......................................................................
Patch Set 2:
(3 comments)
File contrib/scp81_admin_server.py:
https://gerrit.osmocom.org/c/pysim/+/43547/comment/12a3fe47_717a5f91?usp=ema... : PS2, Line 80: 'PSK-AES256-CBC-SHA', I do not see any SHA348 ciphers in that table. From where are those? Or do I have a spec document that is too old? I have: Remote Application Management over HTTP – Public Release – v1.2
https://gerrit.osmocom.org/c/pysim/+/43547/comment/73b76fb8_b64a2a76?usp=ema... : PS2, Line 98: raise ValueError('AID must be at least 5 bytes?! (RID): %r' % aid) This exception string is a it confusing. Is says "(RID)", but its really about the AID? (Also an AID of less then 10 chars cannot contain a valid RID, as a RID must be exactly 10 chars long).
https://gerrit.osmocom.org/c/pysim/+/43547/comment/1ff98d77_24d74e8e?usp=ema... : PS2, Line 116: # similar helpers give us a mutable bytearray which F/$3/$ed me five times already I would recommend to shorten this comment a bit.