Attention is currently required from: Hoernchen, daniel, lynxis lazus.

View Change

3 comments:

• File contrib/scp81_admin_server.py:

  • Patch Set #2, Line 80: 'PSK-AES256-CBC-SHA',

    I do not see any SHA348 ciphers in that table. From where are those? Or do I have a spec document that is too old? I have: Remote Application Management over HTTP – Public Release – v1.2

  • Patch Set #2, Line 98: raise ValueError('AID must be at least 5 bytes?! (RID): %r' % aid)

    This exception string is a it confusing. Is says "(RID)", but its really about the AID? (Also an AID of less then 10 chars cannot contain a valid RID, as a RID must be exactly 10 chars long).

  • Patch Set #2, Line 116: # similar helpers give us a mutable bytearray which F/$3/$ed me five times already

    I would recommend to shorten this comment a bit.

To view, visit change 43547. To unsubscribe, or for help writing mail filters, visit settings.