Attention is currently required from: Hoernchen.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32763 )
Change subject: devices: unify band handling ......................................................................
Patch Set 5:
(4 comments)
Patchset:
PS5: I don't personally see a big win with this, but fine with merging once the comments are discussed/addressed.
File Transceiver52M/device/bladerf/bladerf.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/32763/comment/ce6b1b08_bf60e37e PS5, Line 405: reset(); where does this reset() come from? now that there's 2 superclasses it's a bit confusing.
File Transceiver52M/device/common/bandmanager.h:
https://gerrit.osmocom.org/c/osmo-trx/+/32763/comment/4a8aacc9_54d26c13 PS5, Line 100: void reset() ah here it is. band_reset() would be more descriptive imho.
File Transceiver52M/device/lms/LMSDevice.h:
https://gerrit.osmocom.org/c/osmo-trx/+/32763/comment/3449ae57_eded47b1 PS5, Line 97: using dev_band_key = std::tuple<lms_dev_type, gsm_band>; dev_band_key_t?