Attention is currently required from: Hoernchen.
4 comments:
Patchset:
I don't personally see a big win with this, but fine with merging once the comments are discussed/addressed.
File Transceiver52M/device/bladerf/bladerf.cpp:
Patch Set #5, Line 405: reset();
where does this reset() come from? now that there's 2 superclasses it's a bit confusing.
File Transceiver52M/device/common/bandmanager.h:
Patch Set #5, Line 100: void reset()
ah here it is. band_reset() would be more descriptive imho.
File Transceiver52M/device/lms/LMSDevice.h:
Patch Set #5, Line 97: using dev_band_key = std::tuple<lms_dev_type, gsm_band>;
dev_band_key_t?
To view, visit change 32763. To unsubscribe, or for help writing mail filters, visit settings.