Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/34122 )
Change subject: sgsn_rim: forward message based on RIM ROUTING ADDRESS ......................................................................
Patch Set 1:
(3 comments)
File src/sgsn/sgsn_libgtp.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/34122/comment/ff780a92_1e87046e PS1, Line 707: if (gtpie_gettlv(ie, GTPIE_RIM_RA_DISCR, 0, &rim_ra_encoded_len, rim_ra_encoded, can you move thisgtpie_gettlv() call to be "rc = ..." before the if? I didn't see it was filling some data first, not only checking presence.
https://gerrit.osmocom.org/c/osmo-sgsn/+/34122/comment/a4402f42_7ece8d67 PS1, Line 714: rim_ra_encoded[0] = BSSGP_RIM_ROUTING_INFO_UTRAN; why are you using an array in here? we have no packed struct explaining what is this buffer?
https://gerrit.osmocom.org/c/osmo-sgsn/+/34122/comment/e01d6f0e_53938e64 PS1, Line 715: } rim_ra_encoded++;