Attention is currently required from: dexter.

View Change

3 comments:

• File src/sgsn/sgsn_libgtp.c:

  • Patch Set #1, Line 707: if (gtpie_gettlv(ie, GTPIE_RIM_RA_DISCR, 0, &rim_ra_encoded_len, rim_ra_encoded,

    can you move thisgtpie_gettlv() call to be "rc = ..." before the if? I didn't see it was filling some data first, not only checking presence.

  • Patch Set #1, Line 714: rim_ra_encoded[0] = BSSGP_RIM_ROUTING_INFO_UTRAN;

    why are you using an array in here? we have no packed struct explaining what is this buffer?

  • Patch Set #1, Line 715: }

    rim_ra_encoded++;

To view, visit change 34122. To unsubscribe, or for help writing mail filters, visit settings.