Attention is currently required from: dotsimon, fixeria, lynxis lazus. pespin has posted comments on this change by dotsimon. ( https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email ) Change subject: include SM-RP-UI in outgoing GSUP message when presesnt ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: I'd welcome if you could share the related spec talking about SM-RP-UI here, plus add a bit of rationale in the commit description. File src/libmsc/gsm_04_11_gsup.c: https://gerrit.osmocom.org/c/osmo-msc/+/39428/comment/c8e60483_ac56433d?usp=... : PS2, Line 187: int gsm411_gsup_mt_fwd_sm_res(struct gsm_trans *trans, uint8_t sm_rp_mr, uint8_t *ui) I'd say better pass the len as a separate param here, and pass the buffer as &(ui[1]) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I90a607900ac7c86b200c79b7e8c460d4cbb3c3ce Gerrit-Change-Number: 39428 Gerrit-PatchSet: 2 Gerrit-Owner: dotsimon <implorable-herd@yahoo.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: dotsimon <implorable-herd@yahoo.com> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Wed, 29 Jan 2025 11:51:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No