Attention is currently required from: dotsimon, fixeria, lynxis lazus.

View Change

2 comments:

• Patchset:

  • Patch Set #2:

    I'd welcome if you could share the related spec talking about SM-RP-UI here, plus add a bit of rationale in the commit description.

• File src/libmsc/gsm_04_11_gsup.c:

  • Patch Set #2, Line 187: int gsm411_gsup_mt_fwd_sm_res(struct gsm_trans *trans, uint8_t sm_rp_mr, uint8_t *ui)

    I'd say better pass the len as a separate param here, and pass the buffer as &(ui[1])

To view, visit change 39428. To unsubscribe, or for help writing mail filters, visit settings.