Attention is currently required from: laforge, neels, osmith. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37830?usp=email ) Change subject: osmo-upf: add VTY 'gtp-echo' command ...................................................................... Patch Set 5: (2 comments) File src/osmo-upf/upf_gtpu_echo.c: https://gerrit.osmocom.org/c/osmo-upf/+/37830/comment/aff60f32_cfa79486?usp=... : PS5, Line 130: #define GTP_ECHO_REQ_SIZE ((size_t)(sizeof(struct gtp1u_hdr) + 2)) not really sure what do we win with this define... you can simply uint8_t msgbuf[sizeof(struct gtp1u_hdr) + 2]; sizeof(msgbuf). File src/osmo-upf/upf_vty.c: https://gerrit.osmocom.org/c/osmo-upf/+/37830/comment/51e969be_9e0cbdb2?usp=... : PS5, Line 565: "gtp-echo send to " VTY_IPV46_CMD, let's please rename this to gtp1u-echo -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I970dccd7a27b098eea9e660822e24e2c4b059fc6 Gerrit-Change-Number: 37830 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: osmith <osmith@sysmocom.de> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Mon, 04 Nov 2024 16:44:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No