Attention is currently required from: phcoder. laforge has posted comments on this change by phcoder. ( https://gerrit.osmocom.org/c/pysim/+/41786?usp=email ) Change subject: Print SMSC in read mode ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: I don't think we want to merge this, sorry. `pySim-{read,prog}` are legacy tools that are virtually unmaintained except major bugfixes for many years by now. The proper thing to do is to reimplement the same functionality based on `pySim.filesystem` and all the powerful encoder/decoder functionality we have in `pySim-shell`. But sadly we haven't seen anyone volunteering fo that yet ;) Meanwhilw, if we were to add a new decoder for a file (like SMSP here), it should use the class `pySim.ts_51_011.EF_SMSP()` for decoding and not implement another open-coded/manual encoder. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I17067b68086316d51fd71ba77049874605594e3f Gerrit-Change-Number: 41786 Gerrit-PatchSet: 2 Gerrit-Owner: phcoder <phcoder@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: phcoder <phcoder@gmail.com> Gerrit-Comment-Date: Fri, 09 Jan 2026 10:25:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes