Attention is currently required from: phcoder.
Patch set 2:Code-Review -1
1 comment:
Patchset:
I don't think we want to merge this, sorry. `pySim-{read,prog}` are legacy tools that are virtually unmaintained except major bugfixes for many years by now.
The proper thing to do is to reimplement the same functionality based on `pySim.filesystem` and all the powerful encoder/decoder functionality we have in `pySim-shell`. But sadly we haven't seen anyone volunteering fo that yet ;)
Meanwhilw, if we were to add a new decoder for a file (like SMSP here), it should use the class `pySim.ts_51_011.EF_SMSP()` for decoding and not implement another open-coded/manual encoder.To view, visit change 41786. To unsubscribe, or for help writing mail filters, visit settings.