Attention is currently required from: Hoernchen, fixeria, laforge.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email )
Change subject: transceiver: add optional WebSDR device support ......................................................................
Patch Set 11:
(1 comment)
Patchset:
PS11:
I don't mind refactoring but cluttering everything with ifdefs is not acceptable, we won't be able t […]
I initially implemented this as a separate class (WebTransceiver), but I likely misunderstood comment here https://gerrit.osmocom.org/c/osmo-trx/+/42411/comments/dfb1f065_15681493 when I moved the logic into Transceiver.cpp.
The intention was not to clutter the code with ifdefs, but rather to follow the suggestion and reduce duplication. However, I see your point about keeping the Web-specific logic isolated.
I can revert to the original approach and keep it in a separate WebTransceiver class overriding the required parts.