Attention is currently required from: Hoernchen, fixeria, laforge. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email ) Change subject: transceiver: add optional WebSDR device support ...................................................................... Patch Set 11: (1 comment) Patchset: PS11:

I don't mind refactoring but cluttering everything with ifdefs is not acceptable, we won't be able t […] I initially implemented this as a separate class (WebTransceiver), but I likely misunderstood comment here https://gerrit.osmocom.org/c/osmo-trx/+/42411/comments/dfb1f065_15681493 when I moved the logic into Transceiver.cpp.

The intention was not to clutter the code with ifdefs, but rather to follow the suggestion and reduce duplication. However, I see your point about keeping the Web-specific logic isolated. I can revert to the original approach and keep it in a separate WebTransceiver class overriding the required parts. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d Gerrit-Change-Number: 42411 Gerrit-PatchSet: 11 Gerrit-Owner: Timur Davydov <dtv.comp@gmail.com> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: Hoernchen <ewild@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Wed, 29 Apr 2026 19:26:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild@sysmocom.de>